Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43621 )
Change subject: mainboard/volteer: Enable Tcss D3cold for volteer2, delbin & voxel ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG@7 PS1, Line 7: mainboard mb
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG@9 PS1, Line 9: Power power
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG@9 PS1, Line 9: QS What is QS again?
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG@9 PS1, Line 9: Enable D3cold on QS only for better Power savings. Please add specific numbers, how much power is saved.
https://review.coreboot.org/c/coreboot/+/43621/1//COMMIT_MSG@10 PS1, Line 10: known limitations. Please add the bug report references for the known limitations, or mention the datasheet name and version.