[coreboot-gerrit] Change in coreboot[master]: mb/google/zork: Remove code that reconfigured the backlight GPIO

[Paul Fagerburg (Code Review)]

Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45853 )

Change subject: mb/google/zork: Remove code that reconfigured the backlight GPIO
......................................................................

mb/google/zork: Remove code that reconfigured the backlight GPIO

The SMU code was assuming that GPIO 85 was used for a fan, which caused
interesting backlight flickering.  That has now been fixed, so remove
the code that reconfigured it to a GPIO on resume.

BUG=b:155667589
TEST=Verify the screen does not flicker on resume from S3
BRANCH=Zork

Signed-off-by: Martin Roth 
Change-Id: I6d4f9d98e9df52fefab9b20d0ab0f0b67512d356
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45853
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
Reviewed-by: Marshall Dawson 
Reviewed-by: Rob Barnes 
Reviewed-by: Paul Fagerburg 
---
M src/mainboard/google/zork/mainboard.c
1 file changed, 0 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 4206fdf..f0d9a28 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -188,25 +188,12 @@
    dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator;
 }

-static const struct soc_amd_gpio gpio_set_bl[] = {
-	PAD_GPO(GPIO_85, LOW),
-};
-
-static void reset_backlight_gpio(void *unused)
-{
-	printk(BIOS_DEBUG, "Reset backlight GPIO\n");
-	/* Re-Enable backlight - GPIO 85 active low */
-	/* TODO: Remove this after AGESA stops enabling the fan - b/155667589 */
-	program_gpios(gpio_set_bl, ARRAY_SIZE(gpio_set_bl)); /*  APU_EDP_BL_DISABLE */
-}
-
 static void mainboard_final(void *chip_info)
 {
    struct global_nvs *gnvs;

gnvs = acpi_get_gnvs();

-	reset_backlight_gpio(NULL);

if (gnvs) {
    	gnvs->tmps = CTL_TDP_SENSOR_ID;
@@ -231,5 +218,3 @@
    *size = 0;
    return NULL;
 }
-
-BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, reset_backlight_gpio, NULL);