Attention is currently required from: Benjamin Doron, Felix Singer, Filip Lewiński, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Matt DeVillier, Michał Kopeć, Michał Żygowski.
Lean Sheng Tan has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82721?usp=email )
Change subject: payloads/external/Makefile.mk: build iPXE for EDK2 with custom boot option name
......................................................................
Patch Set 5:
(1 comment)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/82721/comment/05a81be2_f52dc915?usp... :
PS3, Line 152: The Dasharo repository has the following additional options:
I was following the convention of MrChromebox above - I'm not sure Tianocore or MrChromebox would be […]
that is true. What i meant is, like MrCrhomebox or any other repos, there are included as part of kconfig to switch to that specific repo.
Could you follow the similar pattern from MrChromebox to create this kconfig (EDK2_REPO_DASHARO or something similar), and guard this with this kconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82721?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied61c7b8aa7a34261d6c6f7fd089b1affdc7d3f6
Gerrit-Change-Number: 82721
Gerrit-PatchSet: 5
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 09:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Filip Lewiński
filip.lewinski@3mdeb.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com