Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75095 )
Change subject: mb/google/skyrim: Enable DmaProperty on WLAN device
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75095/comment/e4ffc08a_6bd706fd
PS2, Line 10: MMIO
Thanks, I'll fix the typo. The IOMMU is not able to protect against all attacks: […]
Can you add the bug number to these CLs?
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75095/comment/9c8ccc41_f6065f43
PS2, Line 97: register "add_acpi_dma_property" = "true"
Why just WLAN? Why not WWAN also, or even every other PCIe device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06369a19afa5b881b26f5c1eb243e2db41a9bb36
Gerrit-Change-Number: 75095
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Wed, 10 May 2023 17:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Mark Hasemeyer
markhas@google.com
Gerrit-MessageType: comment