Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46556 )
Change subject: sec/intel/txt: Update TXT HEAP and SINIT size ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram... File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram... PS12, Line 307: /* Recent SINIT ACM (COOPERLAKE_SP) are 256KiB but also need 64KiB data size */
what's data size? that's not described in Document Number: 558294
This comes from 572782.
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram... PS12, Line 306: define HEAP_SIZE (1 * MiB) : /* Recent SINIT ACM (COOPERLAKE_SP) are 256KiB but also need 64KiB data size */ : #define SINIT_SIZE ((256 + 64) * KiB)
I'd make Kconfig symbols to handle this
Sounds good.
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram... PS12, Line 415: write64((void *)TXT_SINIT_SIZE, SINIT_SIZE);
according to Document Number: 558294 this should match the SINIT ACM size. […]
This is not true anymore for Cooperlake_SP. Also see 572782