Attention is currently required from: Andrey Petrov, Hannah Williams, Paul Menzel, Subrata Banik, Tarun Tuli.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75524?usp=email )
Change subject: drivers/intel/fsp2_0: Read MRC version from FSP binary ......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75524/comment/6c89c973_a40c854c : PS6, Line 13: Adds
Imperative mood: Add
Done
https://review.coreboot.org/c/coreboot/+/75524/comment/67738204_91606cfb : PS6, Line 13: Adds MRC_VERSION_FROM_BIN Kconfig to restrict flow for unsupported : platform.
Why can’t this be detected at runtime?
added reason in commit msg.
https://review.coreboot.org/c/coreboot/+/75524/comment/9edb0fa9_cde0799a : PS6, Line 17:
Please add a TEST= line.
Done
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/75524/comment/6e6aeeda_e4876f22 : PS3, Line 405: MRC_VERSION_FROM_BIN
Method to get MRC version and header files used for that will be different in ADL/RPL we need to hav […]
@traun ADL/RPL changes will take some more time. I will share more details on bug. @subrata are we okay with MRC_VERSION_FROM_BIN given that we are planning to use MRC_VERSION_FROM_HEADER later ?
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/75524/comment/b6f2c69b_46c859a9 : PS3, Line 15: static union mrc_version mv;
get_mrc_version will give version across code. get_mrc_version part of same c file. […]
can I mark this resolved?