Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39907 )
Change subject: superio/winbond/{w83627hf,w83977tf}: Use macro ......................................................................
Patch Set 2:
(1 comment)
only had a very brief look at the change
https://review.coreboot.org/c/coreboot/+/39907/2/src/superio/winbond/w83627h... File src/superio/winbond/w83627hf/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/39907/2/src/superio/winbond/w83627h... PS2, Line 143: IO (Decode16, 0x004E, 0x004E, 0x01, 0x01) /* this port is used in some configurations, so announce it to be sure */ when using SUPERIO_PNP_BASE, this shouldn't be needed