Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33796 )
Change subject: asus/am1i-a: Fix UART 0 port while preserving UART 1 functionality ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Much better, thank you.
https://review.coreboot.org/#/c/33796/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33796/4//COMMIT_MSG@7 PS4, Line 7: Fix UART 0 port while preserving UART 1 functionality I'd update the summary, e.g.: Enable UART according to CONFIG_UART_FOR_CONSOLE
(commit message would also need an update)
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c File src/mainboard/asus/am1i-a/romstage.c:
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c... PS3, Line 29: CONFIG_TTYS0_BASE
use CONFIG_UART_FOR_CONSOLE […]
The only valid values are 0 and 1, aren't they? Explicitly check for them:
if CONFIG_UART_FOR_CONSOLE == 0 #define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1) #elif CONFIG_UART_FOR_CONSOLE == 1 #define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP2) #else #error "Invalid value for CONFIG_UART_FOR_CONSOLE" #endif
(and while we are at it, let's put UART 0 above UART 1)