Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32089 )
Change subject: soc/intel/cannonlake: Update CPU Ratio base on MSR
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32089/1/src/soc/intel/cannonlake/romstage/fs...
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32089/1/src/soc/intel/cannonlake/romstage/fs...
PS1, Line 74: to be match with MSR settings
"to match existing MSR value"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I959188be46343bc6f2cb3cc149097b4d449802aa
Gerrit-Change-Number: 32089
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 Mar 2019 02:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment