Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31614 )
Change subject: soc/intel/cannonlake: Disable ACPI mode as part of pmc_soc_init
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31614/3/src/soc/intel/cannonlake/pmc.c
File src/soc/intel/cannonlake/pmc.c:
https://review.coreboot.org/#/c/31614/3/src/soc/intel/cannonlake/pmc.c@176
PS3, Line 176: pmc_set_acpi_mode();
my point is that .init may not get called if PMC device is not seeing over bus. […]
That is a valid point. I did not add prints to check if this function is getting called. But I see your point about device not enumerating and hence no init call. Let me run some experiments tomorrow. This will probably have to be moved to BS_DEV_INIT. That is unfortunate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib73883424a8dfd315893ca712ca86c7c08cee551
Gerrit-Change-Number: 31614
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 27 Feb 2019 08:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment