[coreboot-gerrit] Change in coreboot[master]: SMM: Validate more user-provided pointers

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41086 )

Change subject: SMM: Validate more user-provided pointers
......................................................................

Patch Set 15:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... 
File src/soc/intel/baytrail/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... 
PS12, Line 7: #include <commonlib/region.h>
> Did you read my comment in sb/bd82x6x. That one actually needs struct region.

Oh, I thought smm_points_to_smram was in this header. Sorry for the noise, it's actually in src/include/cpu/x86/smm.h

https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... 
PS12, Line 337: break
> Why definetely? The construction is generally that APMC_CNT is passed thru both sb/ an mb/ handler. […]

Not returning when the pointer is invalid is asking for security troubles, AFAIK. In any case the only baytail board does not handle this case anyway.