Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84141?usp=email )
Change subject: mb/google/nissa/var/riven: Update GPIO pins for 3rd dmic support ......................................................................
mb/google/nissa/var/riven: Update GPIO pins for 3rd dmic support
When world-facing camera is absent, coreboot need to enable GPP_R6(DMIC_WCAM_CLK) and GPP_R7(DMIC_WCAM_DATA) for 3rd dmic support
BUG=b:333973512 TEST=Boot google/riven to OS and verify 3rd dmic working properly.
Change-Id: I6c8780ce37b5d3987f5cdf6e6e6d0b4896b33230 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84141 Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Jayvik Desai jayvik@google.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/brya/variants/riven/fw_config.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved Jayvik Desai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/riven/fw_config.c b/src/mainboard/google/brya/variants/riven/fw_config.c index b22463f..ba5460b 100644 --- a/src/mainboard/google/brya/variants/riven/fw_config.c +++ b/src/mainboard/google/brya/variants/riven/fw_config.c @@ -25,10 +25,6 @@ PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), /* H22 : WCAM_MCLK_R */ PAD_NC(GPP_H22, NONE), - /* R6 : DMIC_WCAM_CLK_R */ - PAD_NC(GPP_R6, NONE), - /* R7 : DMIC_WCAM_DATA */ - PAD_NC(GPP_R7, NONE), };
static const struct pad_config stylus_disable_pads[] = {