Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
sorry, I don't know why I accidentally added too many reviewers
This is expected.
The gerrit will add Hung-Te, Yu-Ping and me to the CLs related to MTK platform from now on.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/b9a64dd7_42dc9ec2
PS10, Line 143: bridge->power_on
It seems that all bridge callbacks are required. Just check them before proceeding to the display initialization.
```
if (!bridge || !bridge->power_on || !bridge->get_edid || !bridge->post_power_on)
return -1;
```
And remove the assertions in the below.
(We may need to refactor this file after adding the MIPI support.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 10
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 02:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-MessageType: comment