HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39907 )
Change subject: superio/winbond/{w83627hf,w83977tf}: Use macro
......................................................................
Patch Set 3:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/39907/2/src/superio/winbond/w83627h...
File src/superio/winbond/w83627hf/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/39907/2/src/superio/winbond/w83627h...
PS2, Line 143: IO (Decode16, 0x004E, 0x004E, 0x01, 0x01) /* this port is used in some configurations, so announce it to be sure */
when using SUPERIO_PNP_BASE, this shouldn't be needed
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ac8dd2ba089970a18b460769dfc3fabf9395709
Gerrit-Change-Number: 39907
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 14:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment