[coreboot-gerrit] [L] Change in coreboot[main]: util/dell-flash-unlock: Add utility to unlock internal flashing

[Nicholas Chin (Code Review)]

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79903?usp=email )

Change subject: util/dell-flash-unlock: Add utility to unlock internal flashing
......................................................................

Patch Set 1:

(2 comments)

File util/dell-flash-unlock/COPYING:

PS1: 
Probably not needed?

File util/dell-flash-unlock/accessors.c:

https://review.coreboot.org/c/coreboot/+/79903/comment/fe51406e_88ac5af3 :
PS1, Line 22: uint32_t
            : pci_read_32(uint32_t dev, uint8_t reg)
            : {
            : 	sys_outl(PCI_CFG_ADDR, dev | reg);
            : 	return sys_inl(PCI_CFG_DATA);
            : }
            : 
            : void
            : pci_write_32(uint32_t dev, uint8_t reg, uint32_t value)
            : {
            : 	sys_outl(PCI_CFG_ADDR, dev | reg);
            : 	sys_outl(PCI_CFG_DATA, value);
            : }
I originally did this to avoid any external dependencies, but this probably isn't a safe way of doing PCI access and libpci would probably be better. Flashrom requires libpci anyway.