Attention is currently required from: V Sowmya, Martin Roth, Sugnan Prabhu S, Subrata Banik, Balaji Manigandan.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/49479/comment/b81031eb_6a074949
PS2, Line 35: *num = ARRAY_SIZE(early_gpio_table);
You'll want to add UART GPIOs here, we're pushing to have them set up here instead of in SoC code, see https://review.coreboot.org/q/topic:gpio_soc_to_boards
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 20:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment