Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG@10
PS1, Line 10: overflow.
Please give the exact values. Increase the value from … KB to … KB.
Additionally, it’d be great, if you mentioned what other devices already use that value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7eb64feb91ec29df5402b2fb1bac3ff73cc5bb3
Gerrit-Change-Number: 44326
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 10:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment