18 Oct
2019
18 Oct
'19
2:04 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35626 )
Change subject: superio: add support for IT8380 ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
looks good to me, but the board using this currently doesn't pass the build test yet, so only +1 for now
https://review.coreboot.org/c/coreboot/+/35626/2/src/superio/ite/Makefile.in... File src/superio/ite/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35626/2/src/superio/ite/Makefile.in... PS2, Line 36: subdirs-y += it8380
please put this at the beginning of this block, so that the list is sorted
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/35626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife2bafa073d714d58756510018632e97d86aa280
Gerrit-Change-Number: 35626
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Oct 2019 14:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment