Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/1d427ca9_4289880a PS6, Line 185: register "name" = ""RT58"" suggestion: add a comment that hid is set in `ramstage.c`, e.g.: `# register "hid" is set in ramstage.c because of FW_CONFIG`
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/60bc63c3_638664f0 PS6, Line 19: codec_path, ARRAY_SIZE(codec_path)); nit: this should line up with `pci_root_bus()` on the previous line