Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33485 )
Change subject: mainboard/google/hatch: Scrub Helios GPIOs
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/...
PS2, Line 31: UP_20K
Why is the pull-up required?
I'm not sure how these are handled at the OS level, so I figured a pull-up was safest.
https://review.coreboot.org/#/c/33485/2/src/mainboard/google/hatch/variants/...
PS2, Line 75: DN_20K
Why PD?
I wasn't sure if these needed to be disabled until the OS comes up?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45793ad6515df5af5b925d92106bd943374353d4
Gerrit-Change-Number: 33485
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Jun 2019 20:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment
