Attention is currently required from: Reka Norman, Christian Walter, Tim Wawrzynczak, Eric Lai.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/3d773069_3d1f1bf5
PS1, Line 506: if (!CONFIG(MAINBOARD_HAS_I2C_TI50) && tpm_first_access_this_boot()) {
I think the Kconfig name is misleading, probably something like MAINBOARD_I2C_TI50_WORKAROUND would be better. Eventually it is supposed to fixed and should be compatible with existing drivers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment