You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31024 )
Change subject: mediatek/mt8183: Move some initialization into mt8183_early_init ......................................................................
Patch Set 5:
Patch Set 4:
FWIW, I don't think this needs to be an explicit option. I think it's fine to just say that mtk_wdt_init() must be called by mainboard code at the appropriate point. If you think that's too obscure, you could wrap it in an SoC function like mt8183_early_init() or something like that to make it look more structured.
If anything, really, the appropriate thing to do would probably be to make sure that Kukui works both with and without CONFIG_VBOOT (since that's a user-facing option that can be turned off). So you should wrap all the verstage_mainboard_init() stuff into another function (e.g. mainboard_early_init() or something like that) and make sure it is also called in the !CONFIG_VBOOT case (e.g. from romstage... see the Nyan board which did something similar with early_mainboard_init()).
Done