Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75606?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/meteorlake: Introduce different SoC flavors of Meteor Lake
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75606/comment/9d6ec70f_9558dd9c :
PS1, Line 10: for example: MTL-U, MTL-P and MTL-S.
Could you list all?
https://review.coreboot.org/c/coreboot/+/75606/comment/4e557249_273f37a2 :
PS1, Line 13: ask
task
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/75606/comment/e69996f7_41eda427 :
PS1, Line 20: Important to note that MTL-S SoC combines Compute, GFX, SoC, IOE and PCH die.
Maybe:
Note, MTL-S SoC combines Compute, GFX, SoC, IOE and PCH die.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27404bbbd0b489412953118e140f6f39b6e43426
Gerrit-Change-Number: 75606
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 12:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment