Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43831 )
Change subject: soc/intel/tigerlake: Set default USB3 de-emphasis to -3.5dB
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43831/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43831/1//COMMIT_MSG@10
PS1, Line 10: log
Yeah I can't remember where the original 0x29 value came from, but that is what was used to validate […]
Ack. I can see that default value of 0x29 in FSP UPDs anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia594996cb55523dacce0d4bef98cc217321c62de
Gerrit-Change-Number: 43831
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 Jul 2020 19:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment