14 Apr
2022
14 Apr
'22
2:58 a.m.
Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Reka Norman, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63568 )
Change subject: mb/google/nissa: Add gpio lock pins ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/63568/comment/ae24e192_b5c59be2 PS3, Line 239: PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F14, NONE, LEVEL, INVERT, LOCK_CONFIG),
I think we had issues with wake from locked GPIOs (e.g. […]
haven't test that. What's the Brya's experiment and solution? remove the lock?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63568
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib34ca287596a6958407a944d0caf53f4bcc60d9b
Gerrit-Change-Number: 63568
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 23:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment