Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57140 )
Change subject: soc/tigerlake: Make IO decode / enable register configurable
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS19:
I think it would have been better to simply enable everything. The
current situation where we enable random things by default leads
to incomplete board ports. Looking at the code for boards already
in the tree, we can neither tell what bits they need to be set nor
what bits would conflict if we'd set them all.
Which led to the bad situation, I guess, that somebody needs an
additional bit set but doesn't know if it's safe to do so for all
boards.
It seems too late to fix for older platforms without looking into
a lot of boards or risking regressions. But maybe it's not too
late for Tiger Lake?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1a7f2707e565a5651ebe438320de9597f5742c3
Gerrit-Change-Number: 57140
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 02 Oct 2021 20:53:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment