Attention is currently required from: Sean Rhodes, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60229 )
Change subject: starlabs: Convert EC_GPE_SCI to Kconfig
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/starlabs/labtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/60229/comment/f59de7b8_40a61987
PS10, Line 45: default 0x6e if BOARD_STARLABS_STARBOOK_TGL
The conditional default needs to come before the unconditional default
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189
Gerrit-Change-Number: 60229
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 02 Jan 2022 13:17:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment