[coreboot-gerrit] [M] Change in coreboot[master]: arch/x86/smbios.c: Allow creating entries for empty DIMM slots

[Jonathan Zhang (Code Review)]

Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Angel Pons, lichenchen.carl, Shuming Chu (Shuming), Nill Ge.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )

Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................

Patch Set 3:

(1 comment)

File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/64035/comment/d8ab58df_3d246257 
PS3, Line 298: 	t->part_number = smbios_add_string(t->eos, "");
I did a test on target. A sample "dmidecode -t 17" entry for a slot with DIMM is:
Handle 0x000B, DMI type 17, 40 bytes
Memory Device
    Array Handle: 0x000A
    Error Information Handle: Not Provided
    Total Width: 80 bits
    Data Width: 64 bits
    Size: 16 GB
    Form Factor: RIMM
    Set: None
    Locator: DIMM_A0
    Bank Locator: _Node0_Channel0_Dimm0
    Type: <OUT OF SPEC>
    Type Detail: Synchronous Registered (Buffered)
    Speed: 4800 MT/s
    Manufacturer: Hynix
    Serial Number: 13a442a5
    Asset Tag: DIMM_A0_AssetTag
    Part Number: HMCG78MEBRA107N
    Rank: 1
    Configured Memory Speed: 4400 MT/s
    Minimum Voltage: 1.1 V
    Maximum Voltage: 1.1 V
    Configured Voltage: 1.1 V
    
A sample entry for a empty slot (with this change) is:
Handle 0x000C, DMI type 17, 40 bytes
Memory Device
    Array Handle: 0x000A
    Error Information Handle: Not Provided
    Total Width: Unknown
    Data Width: Unknown
    Size: No Module Installed
    Form Factor: Unknown
    Set: None
    Locator: DIMM_C0
    Bank Locator: _Node0_Channel2_Dimm0
    Type: Unknown
    Type Detail: Other
    
We can see that manufacturer, serial number, asset tag, part number fields are not even displayed for empty slot. So we could remove those 4 statements.