[coreboot-gerrit] [S] Change in coreboot[master]: nb/intel/i945/raminit: Use 'bool' for do_reset

[Martin L Roth (Code Review)]

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68217 )

Change subject: nb/intel/i945/raminit: Use 'bool' for do_reset
......................................................................

nb/intel/i945/raminit: Use 'bool' for do_reset

Signed-off-by: Elyes Haouas 
Change-Id: I692b86bba28853186185846f63dad1dcbfce1eea
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68217
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 18 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 47a37ce..2613b81 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -216,7 +216,7 @@
 static void sdram_detect_errors(struct sys_info *sysinfo)
 {
    u8 reg8;
-	u8 do_reset = 0;
+	bool do_reset = false;

reg8 = pci_read_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2);

@@ -225,7 +225,7 @@
    		printk(BIOS_DEBUG, "SLP S4# Assertion Width Violation.\n");
    		/* Write back clears bit 2 */
    		pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
-			do_reset = 1;
+			do_reset = true;

}

@@ -233,7 +233,7 @@
    		printk(BIOS_DEBUG, "DRAM initialization was interrupted.\n");
    		reg8 &= ~(1 << 7);
    		pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
-			do_reset = 1;
+			do_reset = true;
    	}

/* Set SLP_S3# Assertion Stretch Enable */
@@ -258,12 +258,12 @@
    	if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) ||
    	     (sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) &&
    	    !(mchbar_read8(SLFRCS) & (1 << 0))) {
-			do_reset = 1;
+			do_reset = true;
    	}
    	if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) ||
    	     (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) &&
    	    !(mchbar_read8(SLFRCS) & (1 << 1))) {
-			do_reset = 1;
+			do_reset = true;
    	}
    }