Attention is currently required from: Kane Chen, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59355 )
Change subject: soc/intel/alderlake: Save/restore BAR registers when extract cpu crashlog
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Hi Tim, […]
It's just a PCI device like any other that has BARs that can be assigned by coreboot's resource allocator during PCI enumeration, just like i2c, spi, lpc, pcie controllers, etc. The resource allocator will read the BARs for their size requirements and carve out space for each. All the board has to do is turn the `crashlog` device on in the devicetree and it will get a valid BAR during enumeration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e6772be51ec4f26ef31fed6cb2bddef8ffc6be
Gerrit-Change-Number: 59355
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 18 Nov 2021 22:29:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment