Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42557 )
Change subject: soc/intel/tigerlake: Disable CPU PCIe in FSP
......................................................................
Patch Set 5:
(9 comments)
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@7
PS3, Line 7: PCIE
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@9
PS3, Line 9: iIn
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@9
PS3, Line 9: Pcie
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@9
PS3, Line 9: soc
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@10
PS3, Line 10: Pcie
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@11
PS3, Line 11: Pcie
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3//COMMIT_MSG@18
PS3, Line 18: this patch.
Will fix
Done
https://review.coreboot.org/c/coreboot/+/42557/3/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42557/3/src/soc/intel/tigerlake/rom...
PS3, Line 207: Pcie
PCIe
Done
https://review.coreboot.org/c/coreboot/+/42557/3/src/soc/intel/tigerlake/rom...
PS3, Line 208: 0
Thanks for the review. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e8512d22b1463bc4207f80b16dcfb5d00ef4b46
Gerrit-Change-Number: 42557
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 22 Jul 2020 07:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment