Attention is currently required from: Jonathon Hall, Martin L Roth, Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change by Jonathon Hall. ( https://review.coreboot.org/c/coreboot/+/83476?usp=email )
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
......................................................................
Patch Set 2:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/83476/comment/21a302f4_8b0c4513?usp... :
PS2, Line 507: default 0x400000 if BOOTSPLASH
Why not adding this as another default to src/Kconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83476?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Gerrit-Change-Number: 83476
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Nigel Tao
nigeltao@golang.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Comment-Date: Fri, 19 Jul 2024 17:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No