Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84220?usp=email )
Change subject: drivers/intel/fsp2_0: Consolidate `BUILDING_WITH_DEBUG_FSP` option ......................................................................
drivers/intel/fsp2_0: Consolidate `BUILDING_WITH_DEBUG_FSP` option
Move the `BUILDING_WITH_DEBUG_FSP` Kconfig option from SoC-specific files to the FSP2_0 driver Kconfig to avoid duplication. Also slightly improves the option's prompt and help text.
TEST=Built and booted google/rex successfully.
Change-Id: I5c3dce59c396f6c1665a3ed1b8c1bb5df0f5a8d4 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84220 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/drivers/intel/fsp2_0/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/pantherlake/Kconfig 4 files changed, 7 insertions(+), 18 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index bbf0710..8e9dcdc 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -533,4 +533,11 @@ ChromeOS devices typically do not require the MBP information, hence it is disabled by default on ChromeOS.
+config BUILDING_WITH_DEBUG_FSP + bool "Use Debug FSP for Build" + default n + help + Enable this option if you are using a debug build of the FSP (Firmware Support Package) + in your project. + endif diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index c1cc993..2c441fc 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -493,12 +493,6 @@ help Size of Descriptor Region in the FMAP
-config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - config INTEL_GMA_BCLV_OFFSET default 0xc8258
diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 753af7c..b5c0bcf 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -380,12 +380,6 @@ hex default 0x800000
-config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - config DROP_CPU_FEATURE_PROGRAM_IN_FSP bool default y if MP_SERVICES_PPI_V2_NOOP || CHROMEOS diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig index e5f7c92..98248fe 100644 --- a/src/soc/intel/pantherlake/Kconfig +++ b/src/soc/intel/pantherlake/Kconfig @@ -242,10 +242,4 @@ int default 16
-config BUILDING_WITH_DEBUG_FSP - bool "Debug FSP is used for the build" - default n - help - Set this option if debug build of FSP is used. - endif