Attention is currently required from: Tim Wawrzynczak, Peter Marheine. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63733 )
Change subject: ec/google/chromeec: allow custom command timeout ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63733/comment/cc2ea0ac_fd6e5c1a PS1, Line 15: timeout field is zero-initialized when the default should be used Why can’t it be initialized to 1 s explicitly? Having 0 mean different things, is not nice in my opinion.
https://review.coreboot.org/c/coreboot/+/63733/comment/e6584633_20b74db0 PS1, Line 17: When is EC flash erase done, that means, when will the user experience that? Should some message logged, when it is taking longer than a few milliseconds (separate commit)?
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/63733/comment/3c06ab71_4088af35 PS1, Line 157: uint32_t timeout_us; /* maximum time to wait for command completion Why not use a native type?