7 Oct
2019
7 Oct
'19
3:40 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35825 )
Change subject: cpu/amd/pi: Don't redefine XIP_ROM_SIZE ......................................................................
Patch Set 1:
I don't see XIP_ROM_SIZE referenced with AGESA or binaryPI anywhere, amd_initmmio() sets CACHE_ROM_SIZE as WRPROT early in romstage. Looks like you can remove them all and select NO_FIXED_XIP_ROM_SIZE.
Only non-AGESA AMD uses cpu/amd/car/ where you see CONFIG_XIP_ROM_SIZE.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35825
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I548b9c9066d825c2f03749353b9990b2efddfd9c
Gerrit-Change-Number: 35825
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 07 Oct 2019 03:40:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment