Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nico Huber.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80695/comment/584e3527_770b6679 : PS3, Line 15: - All enum names now use the `AZALIA_` prefix.
what for? I would rather remove it
I stated my reason here: https://review.coreboot.org/c/coreboot/+/80577/comments/d3f8e945_d2cbea76. However, I'm completely fine with dropping the prefixes.
https://review.coreboot.org/c/coreboot/+/80695/comment/34a539bf_26cd54f8 : PS3, Line 16: - Locations are now expressed using a combination of ORs (e.g. : `AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT`). :
This should be a separate change
Will upload the other change tomorrow.
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/8faa8087_1282c57f : PS3, Line 85: = 0x2,
It's a enum, do we really want to have explicit values here?
I prefer to only use implicit values when you **only** need uniqueness. For instance, you could assign a random unique value to a particular enum, or change the order of the enums and the program should still work. In this case, the values are technically an enumeration but they are set in stone in the specification. In other words these enum must be assigned to these values.
That being said same with the prefix, this is not my project and I'm fine with using implicit values. :)