Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38214 )
Change subject: asus/am1i-a: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@11 PS3, Line 11: It does not bring any downsides if there is no discrete VGA adapter.
For the record, this is how breaking at 75 chars looks like in a narrow […]
Done.
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@14 PS3, Line 14: IO
You are referring to MMIO, right? IO is easily confused with i/o ports. […]
Yes, memory mapped IO. Maybe I should do like this commit - https://gitlab.miaounyan.eu/piernov/coreboot/commit/27c3dcb522722026479462dd... - for fam14, fam15 and fam16 boards.
https://review.coreboot.org/c/coreboot/+/38214/3/src/mainboard/asus/am1i-a/O... File src/mainboard/asus/am1i-a/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38214/3/src/mainboard/asus/am1i-a/O... PS3, Line 152: InitPost->MemConfig.BottomIo = 0xD0;
Is this about MMIO? is the value shifted by 24 bit?
Yes, about MMIO and it is shifted by 24 bit. From ./src/vendorcode/amd/agesa/f16kb/AGESA.h :
// Advanced (Optional parameters) // Optional (all defaults values will be initialized by the // 'AmdMemInitDataStructDef' based on AMD defaults. It is up // to the IBV/OEM to change the defaults after initialization // but prior to the main entry to the memory code):
// Memory Map/Mgt.
IN UINT16 BottomIo; ///< Bottom of 32-bit IO space (8-bits). ///< NV_BOTTOM_IO[7:0]=Addr[31:24] ///<
https://review.coreboot.org/c/coreboot/+/38214/5/src/mainboard/asus/am1i-a/O... File src/mainboard/asus/am1i-a/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38214/5/src/mainboard/asus/am1i-a/O... PS5, Line 151: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info about this change from 0xD0 to 0x40 - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...