Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: mediatek/mt8183: Clean the calibration result if calibration or mem test fail ......................................................................
Patch Set 10:
(5 comments)
A spell checker would have found some of the typos.
https://review.coreboot.org/c/coreboot/+/35481/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35481/10//COMMIT_MSG@10 PS10, Line 10: store stores?
Better:
… the calibration result stored in flash, and
https://review.coreboot.org/c/coreboot/+/35481/10//COMMIT_MSG@11 PS10, Line 11: triggle trigger
https://review.coreboot.org/c/coreboot/+/35481/10/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35481/10/src/soc/mediatek/mt8183/dr... PS10, Line 1970: dramc_show("system will be reboot in 5 secoeds.\n"); System is going to reboot in 5 seconds.
https://review.coreboot.org/c/coreboot/+/35481/10/src/soc/mediatek/mt8183/dr... PS10, Line 1971: delay(5); Why such a high delay? Please add a comment and elaborate in the commit message.
https://review.coreboot.org/c/coreboot/+/35481/10/src/soc/mediatek/mt8183/dr... PS10, Line 1971: 5 Please add a macro or variable/constant, and also use that in the debug message.