Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
File src/mainboard/starlabs/byte_adl/cmos.default:
https://review.coreboot.org/c/coreboot/+/80705/comment/9381936c_2380622c?usp... : PS7, Line 9: Balanced for a device which is always connected to external power, any reason to not use performance here?
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80705/comment/bca2112d_90d35455?usp... : PS7, Line 4: SaGv_Enabled necessary/desired for a desktop device? setting to highest freq only should save some RAM training time
https://review.coreboot.org/c/coreboot/+/80705/comment/d23a5170_ec790b4f?usp... : PS7, Line 143: end EC interface isn't used for fan control etc?