Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45686 )
Change subject: [WIP]mb/prodrive/hermes: Improve board config EEPROM handling
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45686/3/src/mainboard/prodrive/herm...
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45686/3/src/mainboard/prodrive/herm...
PS3, Line 77: if (check_board_settings_signature(I2C_ADDR_EEPROM)) {
this results in […]
Fixed in CB:46562
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f83d1ddb455a3d0aaec9757666d161f2091cec2
Gerrit-Change-Number: 45686
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Oct 2020 08:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment