[coreboot-gerrit] [S] Change in coreboot[master]: mb/amd/birman&mayan: Use relative address as EC address

[Bao Zheng (Code Review)]

Attention is currently required from: Jason Glenesk, Zheng Bao, Fred Reitberger, Felix Held.

Hello Zheng Bao,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/72960

to review the following change.

Change subject: mb/amd/birman&mayan: Use relative address as EC address
......................................................................

mb/amd/birman&mayan: Use relative address as EC address

TEST=binary identical test on birman and mayan

Change-Id: I65be3039cd3449bfb481ad87281b72e88a58bd45
Signed-off-by: Zheng Bao 
---
M src/mainboard/amd/birman/Makefile.inc
M src/mainboard/amd/mayan/Makefile.inc
2 files changed, 14 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72960/1

diff --git a/src/mainboard/amd/birman/Makefile.inc b/src/mainboard/amd/birman/Makefile.inc
index a19cb35..92c0f9f 100644
--- a/src/mainboard/amd/birman/Makefile.inc
+++ b/src/mainboard/amd/birman/Makefile.inc
@@ -27,14 +27,9 @@
 $(call add_intermediate, add_mchp_fw)
    $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_BIRMAN_MCHP_SIG_FILE) --fill-upward

-# calculate the absolute position from the config offset
-BIRMAN_EC_POSITION=$(call int-add, \
-	$(call int-subtract, 0xffffffff \
-	$(CONFIG_ROM_SIZE)) $(CONFIG_BIRMAN_MCHP_FW_OFFSET) 1)
-
 cbfs-files-y += apu/ecfw
 apu/ecfw-file := $(CONFIG_BIRMAN_MCHP_FW_FILE)
-apu/ecfw-position := $(BIRMAN_EC_POSITION)
+apu/ecfw-position := $(CONFIG_BIRMAN_MCHP_FW_OFFSET)
 apu/ecfw-type := raw

else
diff --git a/src/mainboard/amd/mayan/Makefile.inc b/src/mainboard/amd/mayan/Makefile.inc
index 1fbeccd..2d6fa26 100644
--- a/src/mainboard/amd/mayan/Makefile.inc
+++ b/src/mainboard/amd/mayan/Makefile.inc
@@ -21,14 +21,9 @@
 $(call add_intermediate, add_mchp_fw)
    $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_MAYAN_MCHP_SIG_FILE) --fill-upward

-# calculate the absolute position from the config offset
-MAYAN_EC_POSITION=$(call int-add, \
-	$(call int-subtract, 0xffffffff \
-	$(CONFIG_ROM_SIZE)) $(CONFIG_MAYAN_MCHP_FW_OFFSET) 1)
-
 cbfs-files-y += ec/ecfw
 ec/ecfw-file := $(CONFIG_MAYAN_MCHP_FW_FILE)
-ec/ecfw-position := $(MAYAN_EC_POSITION)
+ec/ecfw-position := $(CONFIG_MAYAN_HAVE_MCHP_FW)
 ec/ecfw-type := raw

else