Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kane Chen, Kapil Porwal, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79654?usp=email )
Change subject: soc/intel/mtl: Enable SOC_INTEL_COMMON_BLOCK_SMM_TCO_ENABLE
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79654/comment/268010c5_0872cc29 :
PS2, Line 9: we found a system hung
When did it hang?
https://review.coreboot.org/c/coreboot/+/79654/comment/7c89dc7d_6ba43d20 :
PS2, Line 9: hung
hang
https://review.coreboot.org/c/coreboot/+/79654/comment/a04879c2_3e94f8c0 :
PS2, Line 12: when LOCK_ENABLE bit within the
: SPI_BIOS_CONTROL register and asserting WPD (Write Protect Disable)
: from 0 to 1
Maybe:
when LOCK_ENABLE bit is set within the
SPI_BIOS_CONTROL register and WPD (Write Protect Disable)
is asserted from 0 to 1
https://review.coreboot.org/c/coreboot/+/79654/comment/1351e02f_39461a57 :
PS2, Line 20: 20 systems
20 identical screebo systems?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1f096f8eda4adcf1627e44afa517b02adddad76
Gerrit-Change-Number: 79654
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 19 Jan 2024 10:37:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment