Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/18011 )
Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/18011/11/src/mainboard/lenovo/t430/romstage.... File src/mainboard/lenovo/t430/romstage.c:
PS11, Line 36: 0x10001fe0
Maybe put a TODO here to investigate, if setting the reserved bits
OK
Line 39: /* FIXME: used T530 values here */
What exactly went wrong? no output? insane output? Bug report
Have a look at patchset 1-2. That's the original autoport generated output. Patchset 3 moved it to romstage.c.
I do not have schematics for T430.
I guess the RCBA registers needs to be dumped on vendor BIOS ?
I'll remove the comments.