Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38216 )
Change subject: [TESTME]msi/ms7721: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 1:
Patch Set 1:
First of all: thank you for putting in such effort to fix issues with this motherboard!
I'd love to review your work but I'm quite busy at the moment. I expect to be able to test this change somewhere around February or March 2020.
(On a sidenote and slightly off-topic: if you're willing to look into stuff for these boards, there are a couple of other issues that might need fixing... the ms7721 board does not properly wake up from sleep mode, doesn't always come back after a reboot and doesn't save settings to nvram properly as well, if you have any idea of why this may be please do let me know!)
Fun thing about the specific issue named in this pr is that I tested the 16x PCIe port using a graphics card when I initially added support for this board to coreboot and it did work back then. What kind of things can I expect to see when testing this patch? Do these "resource allocation problems" cause the external graphics card not to display/initialise properly?
Thank you very much too, for your reply! ;) As I don't have this motherboard, I could provide a fix only for the issues I've encountered on the other boards, and hope it would work for you as well - asking to [TESTME]. A few months ago indeed there was a problem with a "sleep mode" aka S3 Suspend, and after entering this broken mode it was impossible to power on until you'd completely discharge a board (i.e. by attempting to power on a board when its' power supply isn't connected to electricity, to discharge it completely). But this has been fixed recently, so a "sleep mode" should work for you fine.
Please tell, with what graphics card you have tested? I reproduce this issue with AMD HD6670 GPU on some different desktop AGESA boards. Also, I haven't observed any downsides from this fix yet. Check out this comment by Michal for more info about this fix - https://review.coreboot.org/c/coreboot/+/38224/2#message-efd01244126362afe68...