build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ......................................................................
Patch Set 39:
(7 comments)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... File src/soc/intel/common/block/cpu/mp_service_ppi.c:
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 47: EFI_PEI_SERVICES **ignored1, EFI_PEI_MP_SERVICES_PPI *ignored2, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 60: static EFI_STATUS mp_get_processor_info(CONST EFI_PEI_SERVICE **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 85: static EFI_STATUS mp_startup_all_aps(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 104: static EFI_STATUS mp_startup_this_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 130: static EFI_STATUS mp_switch_bsp(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 138: static EFI_STATUS mp_enable_disable_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/39/src/soc/intel/common/block/cpu/mp_s... PS39, Line 145: static EFI_STATUS mp_identify_processor(CONST EFI_PEI_SERVICES **PeiServices, need consistent spacing around '*' (ctx:WxO)