Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31507 )
Change subject: soc/amd: Remove defined but unwritten functions ......................................................................
soc/amd: Remove defined but unwritten functions
There are functions defined on headers with no code written for. They probably existed earlier, were removed and forgot in the headers. Remove functions from headers if there's no actual code written for.
BUG=b:123564495 TEST=Build grunt.
Change-Id: Ia6a12e22a0944351c455dc2c3b534f09a258bd7b Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-on: https://review.coreboot.org/c/31507 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/stoneyridge/include/soc/northbridge.h M src/soc/amd/stoneyridge/include/soc/southbridge.h 2 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/include/soc/northbridge.h b/src/soc/amd/stoneyridge/include/soc/northbridge.h index d62c791..3b60400 100644 --- a/src/soc/amd/stoneyridge/include/soc/northbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/northbridge.h @@ -121,10 +121,8 @@ */ int smm_subregion(int sub, void **start, size_t *size); void domain_enable_resources(struct device *dev); -void domain_read_resources(struct device *dev); void domain_set_resources(struct device *dev); void fam15_finalize(void *chip_info); -void setup_uma_memory(void); uint32_t nb_ioapic_read(unsigned int index); void nb_ioapic_write(unsigned int index, uint32_t value); void *get_ap_entry_ptr(void); diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h index 705fe7a..4d1448c 100644 --- a/src/soc/amd/stoneyridge/include/soc/southbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h @@ -477,7 +477,6 @@
void enable_aoac_devices(void); void sb_enable_rom(void); -void configure_stoneyridge_i2c(void); void sb_clk_output_48Mhz(u32 osc); void sb_disable_4dw_burst(void); void sb_enable(struct device *dev);