Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Sean Rhodes, Subrata Banik.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81906?usp=email )
Change subject: soc/intel/alderlake: Hook up PCI Power Management to option API ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81906/comment/45d620ed_b2665922?usp... : PS8, Line 7: PCI nit: PCIe
https://review.coreboot.org/c/coreboot/+/81906/comment/125d0102_cd655c96?usp... : PS8, Line 9: PCICLK_PM Can't find this symbol
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81906/comment/8ceb20be_90c40572?usp... : PS8, Line 535: bool pciexp_clk_pm = get_uint_option("pciexp_clk_pm", CONFIG(PCIEXP_CLK_PM)); : bool pciexp_aspm = get_uint_option("pciexp_aspm", CONFIG(PCIEXP_ASPM)); : bool pciexp_l1_sub_state = get_uint_option("pciexp_l1_sub_state", : CONFIG(PCIEXP_L1_SUB_STATE)); I would prefer to only call the option API once per option