Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email )
Change subject: soc/mediatek/common: Refactor EINT driver
......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/83703/comment/0c83849b_cf675842?usp... :
PS2, Line 122: void pos_bit_calc_for_eint(gpio_t gpio, u32 *pos, u32 *bit);
: void *eint_find_reg_addr(gpio_t gpio);
Since these functions are still declared here in gpio_common.h and are related to gpio, how about: […]
Done
https://review.coreboot.org/c/coreboot/+/83703/comment/ed495bca_0c73c6ba?usp... :
PS2, Line 123: void
struct eint_regs
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83703?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973
Gerrit-Change-Number: 83703
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 07:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com