Attention is currently required from: Eric Lai, Felix Singer, Kangheui Won, Reka Norman, Tarun Tuli, Yunlong Jia.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75872?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add GPIO table for gothrax
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
File src/mainboard/google/brya/variants/gothrax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75872/comment/e45387b8_cad47e28 :
PS6, Line 4: romstage-y += memory.c
There is no memory.c exist, is it buildable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If852c7a30edb9fb778872414cb15dc3446aebc55
Gerrit-Change-Number: 75872
Gerrit-PatchSet: 6
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 26 Jun 2023 02:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment