[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )

Change subject: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43741/19/src/drivers/spi/tpm/tpm.c 
File src/drivers/spi/tpm/tpm.c:

https://review.coreboot.org/c/coreboot/+/43741/19/src/drivers/spi/tpm/tpm.c@... 
PS19, Line 510: 	if (get_cr50_board_cfg() & CR50_BOARD_CFG_100US_READY_PULSE)
> Honestly, long-term, I would prefer we just got rid of tlcl_lib_init() (and this whole tis_xxx() API […]

Is tlcl_lib_init() invoked to setup the GSPI controller? If so, setting up the GSPI controller  can be done here. Since the TPM SPI device structure is local to this driver, it can be initialized once and re-used by all the subsequent use-cases.